[Search] Add new RCF use_document_level_security in Salesforce native configs
#183600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarone-feekery
added
release_note:skip
| sensitive: false, | ||
| tooltip: getEnableDocumentLevelSecurityTooltip( | ||
| i18n.translate('searchConnectors.content.nativeConnectors.salesforce.useDocumentLevelSecurity.tooltip', { | ||
| defaultMessage: 'Salesforce', |
There was a problem hiding this comment.
Can you use the const USE_TEXT_EXTRACTION_SERVICE_TOOLTIP instead of creating a new translation string here?
There was a problem hiding this comment.
Oh I'm just blind, I see it's a func. Nevermind.
There was a problem hiding this comment.
That being said, the translation key should be different:
searchConnectors.nativeConnectors.salesforce.name
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
navarone-feekery
approved these changes
May 16, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2024
…ve configs (elastic#183600) ## Summary Related to elastic/connectors#2566. With the introduction of new RCF `use_document_level_security` in the Salesforce connector, the same needs to be reflected in native Confluence connector. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit fb8ba21)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2024
…ve configs (elastic#183600) ## Summary Related to elastic/connectors#2566. With the introduction of new RCF `use_document_level_security` in the Salesforce connector, the same needs to be reflected in native Confluence connector. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit fb8ba21)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 16, 2024
…n Salesforce native configs (#183600) (#183634) # Backport This will backport the following commits from `main` to `8.14`: - [[Search] Add new RCF `use_document_level_security` in Salesforce native configs (#183600)](#183600) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"moxarth-elastic","email":"96762084+moxarth-elastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-16T12:00:53Z","message":"[Search] Add new RCF `use_document_level_security` in Salesforce native configs (#183600)\n\n## Summary\r\n\r\nRelated to elastic/connectors#2566. With the\r\nintroduction of new RCF `use_document_level_security` in the Salesforce\r\nconnector, the same needs to be reflected in native Confluence\r\nconnector.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fb8ba21e28fe0152eeb21f2a0d6622ed36787ebf","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.13.0","v8.14.0","v8.15.0"],"title":"[Search] Add new RCF `use_document_level_security` in Salesforce native configs","number":183600,"url":"#183600 Add new RCF `use_document_level_security` in Salesforce native configs (#183600)\n\n## Summary\r\n\r\nRelated to elastic/connectors#2566. With the\r\nintroduction of new RCF `use_document_level_security` in the Salesforce\r\nconnector, the same needs to be reflected in native Confluence\r\nconnector.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fb8ba21e28fe0152eeb21f2a0d6622ed36787ebf"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.14"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/183600","number":183600,"mergeCommit":{"message":"[Search] Add new RCF `use_document_level_security` in Salesforce native configs (#183600)\n\n## Summary\r\n\r\nRelated to elastic/connectors#2566. With the\r\nintroduction of new RCF `use_document_level_security` in the Salesforce\r\nconnector, the same needs to be reflected in native Confluence\r\nconnector.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n### For maintainers\r\n\r\n- [ ] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"fb8ba21e28fe0152eeb21f2a0d6622ed36787ebf"}}]}] BACKPORT--> Co-authored-by: moxarth-elastic <96762084+moxarth-elastic@users.noreply.github.com>
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
3 similar comments
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to elastic/connectors#2566. With the introduction of new RCF
use_document_level_securityin the Salesforce connector, the same needs to be reflected in native Confluence connector.Checklist
Delete any items that are not applicable to this PR.
For maintainers