-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add data tags to agent policy APIs #183563
[Fleet] Add data tags to agent policy APIs #183563
Conversation
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
117dd2d
to
5fa637d
Compare
5fa637d
to
95d7c13
Compare
x-pack/plugins/fleet/server/services/agent_policies/package_policies_to_agent_inputs.ts
Show resolved
Hide resolved
you can run the build on a draft pr by commenting /ci |
/ci |
x-pack/plugins/fleet/server/services/agent_policies/package_policies_to_agent_inputs.ts
Show resolved
Hide resolved
a59bd0f
to
a381253
Compare
24bade0
to
ea67e20
Compare
0b124db
to
ed4e3ee
Compare
e7b981b
to
93b384a
Compare
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Canvas Sharable Runtime
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
## Summary This PR updates kibana backend so that users can add global data tags to agent policy inputs Relates: elastic#179915 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Manual Testing - start elasticsearch and kibana - navigate to stack management and create an api key - download agent - create agent policy with system integration - update the agent to add data tags ``` curl --location --request PUT 'http://localhost:5601/api/fleet/agent_policies/:policyId' \ --header 'Content-Type: application/json' \ --header 'Authorization: ApiKey <your api key>' \ --header 'Elastic-Api-Version: 2023-10-31' \ --header 'kbn-xsrf: true' \ --data '{ "name": "asdfasdf", "namespace": "default", "global_data_tags": [ { "name": "newtag", "value": "testing" } ] }' ``` - deploy a standalone agent - go to the discovery tab and search for the tag name and validate that the values are populated. (note: seeing a value may take some time, 2~3 min) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
This PR updates kibana backend so that users can add global data tags to agent policy inputs
Relates: #179915
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Manual Testing