Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkIndexer throw error when es.Client not provided ? #462

Open
mayankvaid88 opened this issue Apr 8, 2022 · 0 comments
Open

BulkIndexer throw error when es.Client not provided ? #462

mayankvaid88 opened this issue Apr 8, 2022 · 0 comments

Comments

@mayankvaid88
Copy link

Currently, NewBulkInderxer function creates a elasticsearch.Client with default ES URL=localhost:9200 in case if it is not provided by the consumer. In most of the PROD ready applications ES Url address would be different from the default address and it makes sense to give a feedback in terms of error rather than creating it to default. This will help in getting an early feedback to the consumer to course correct it.
https://github.com/elastic/go-elasticsearch/blob/main/esutil/bulk_indexer.go#L190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant