Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] Linting Emotion/CSS-in-JS #6477

Closed
cee-chen opened this issue Dec 13, 2022 · 1 comment · Fixed by #6839
Closed

[Tech debt] Linting Emotion/CSS-in-JS #6477

cee-chen opened this issue Dec 13, 2022 · 1 comment · Fixed by #6839
Assignees

Comments

@cee-chen
Copy link
Member

cee-chen commented Dec 13, 2022

We recently switched to stylelint to remove our deprecated sass-lint dependency (#6470) and also in hopes that stylelint could be configured to lint our CSS-in-JS styles.

Unfortunately, it looks like the latter is not actually the case, and the stylelint folks have offloaded the onus of parsing/processing CSS-in-JS syntax to other library owners:

I investigated a workaround posted primarily for styled-components that somewhat works for Emotion - unfortunately, it falls over/reports a bunch of CssSyntaxError errors on // comments in our CSS-in-JS code, which I don't see a way around for.

I'm opening this issue to track any movement on either stylelint or Emotion's end that would make this work possible, and to log it as a blocked, low priority tech debt item.

If no movement in the future has been for stylelint Emotion linting, and we complete our Emotion conversion and have no meaningful Sass left in our codebase, we should consider seeking another linter specifically for Emotion that works.

@github-actions
Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant