Skip to content

Do not emit deprecation warning in the shared context [7.17] #93190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

idegtiarenko
Copy link
Contributor

Related to: #93183

@idegtiarenko idegtiarenko added >test-failure Triaged test failures from CI Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.17.0 labels Jan 24, 2023
@idegtiarenko idegtiarenko changed the title Do not emit deprecation warning in the shared context Do not emit deprecation warning in the shared context [7.17] Jan 24, 2023
@idegtiarenko idegtiarenko added :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. and removed v7.17.0 labels Jan 24, 2023
@idegtiarenko idegtiarenko marked this pull request as ready for review January 24, 2023 10:22
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@idegtiarenko
Copy link
Contributor Author

@elasticsearchmachine please run elasticsearch-ci/part-1

@idegtiarenko
Copy link
Contributor Author

idegtiarenko commented Jan 24, 2023

It seems there is a test that relies on this behavior: https://gradle-enterprise.elastic.co/scans/tests?search.timeZoneId=Europe/Berlin&tests.container=org.elasticsearch.analysis.common.CommonAnalysisClientYamlTestSuiteIT&tests.test=test%20%7Byaml%3Dindices.analyze/10_analyze/htmlStrip_deprecated%7D that emits warning at:

	at org.elasticsearch.analysis.common.CommonAnalysisPlugin.lambda$getPreConfiguredCharFilters$10(CommonAnalysisPlugin.java:454)
	at org.elasticsearch.index.analysis.PreConfiguredCharFilter$2.create(PreConfiguredCharFilter.java:118)
	at org.elasticsearch.index.analysis.CustomAnalyzer.initReader(CustomAnalyzer.java:96)
	at org.apache.lucene.analysis.AnalyzerWrapper.initReader(AnalyzerWrapper.java:156)
	at org.apache.lucene.analysis.Analyzer.tokenStream(Analyzer.java:197)
	at org.elasticsearch.index.analysis.AnalysisRegistry.checkVersions(AnalysisRegistry.java:757)
	at org.elasticsearch.index.analysis.AnalysisRegistry.produceAnalyzer(AnalysisRegistry.java:720)
	at org.elasticsearch.index.analysis.AnalysisRegistry.build(AnalysisRegistry.java:612)
	at org.elasticsearch.index.analysis.AnalysisRegistry.build(AnalysisRegistry.java:218)
	at org.elasticsearch.index.IndexModule.newIndexService(IndexModule.java:454)
	at org.elasticsearch.indices.IndicesService.createIndexService(IndicesService.java:723)
	at org.elasticsearch.indices.IndicesService.withTempIndexService(IndicesService.java:665)
	at org.elasticsearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexWithTemporaryService(MetadataCreateIndexService.java:451)
	at org.elasticsearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequestWithV1Templates(MetadataCreateIndexService.java:567)
	at org.elasticsearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:413)
	at org.elasticsearch.cluster.metadata.MetadataCreateIndexService.applyCreateIndexRequest(MetadataCreateIndexService.java:420)
	at org.elasticsearch.cluster.metadata.MetadataCreateIndexService$1.execute(MetadataCreateIndexService.java:319)
	at org.elasticsearch.cluster.ClusterStateUpdateTask.execute(ClusterStateUpdateTask.java:51)
	at org.elasticsearch.cluster.service.MasterService.executeTasks(MasterService.java:840)
	at org.elasticsearch.cluster.service.MasterService.calculateTaskOutputs(MasterService.java:407)
	at org.elasticsearch.cluster.service.MasterService.runTasks(MasterService.java:243)
	at org.elasticsearch.cluster.service.MasterService.access$100(MasterService.java:63)
	at org.elasticsearch.cluster.service.MasterService$Batcher.run(MasterService.java:170)
	at org.elasticsearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:146)
	at org.elasticsearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:202)
	at org.elasticsearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:718)
	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedEsThreadPoolExecutor.java:262)
	at org.elasticsearch.common.util.concurrent.PrioritizedEsThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedEsThreadPoolExecutor.java:225)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idegtiarenko idegtiarenko merged commit a7452b2 into elastic:7.17 Jan 26, 2023
@idegtiarenko idegtiarenko deleted the fix_leaking_deprecation_7 branch January 26, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test-failure Triaged test failures from CI v7.17.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants