Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update language around eliminating replica shards #90369

Merged
merged 1 commit into from Sep 26, 2022
Merged

update language around eliminating replica shards #90369

merged 1 commit into from Sep 26, 2022

Conversation

sunilemanjee
Copy link

Replica shards are required to avoid data loss during indexing. Therefore IMHO the language should be changed

from
Searchable snapshots eliminate the need for replica shards
to
Searchable snapshots eliminate the need for replica shards after rollover from hot

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@sunilemanjee
update language around eliminating replica shards
2cf323d 
Replica shards required to avoid data loss during indexing.  Therefore IMHO the language should be changed

 from 
Searchable snapshots eliminate the need for replica shards 
to
Searchable snapshots eliminate the need for replica shards after rollover from hot
@elasticsearchmachine
Copy link
Collaborator

@sunilemanjee please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.4.3 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Sep 26, 2022
@lcawl lcawl added the >docs General docs changes label Sep 26, 2022
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Sep 26, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@lcawl lcawl added the needs:triage Requires assignment of a team area label label Sep 26, 2022
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Sep 26, 2022
kilfoyle
kilfoyle approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thanks for adding this @sunilemanjee

@kilfoyle kilfoyle merged commit 7230f85 into 8.4 Sep 26, 2022
@kilfoyle kilfoyle deleted the sunilemanjee-branch.8.4 branch September 26, 2022 17:28
@kilfoyle kilfoyle added auto-backport-and-merge Automatically create backport pull requests and merge when ready and removed auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Sep 26, 2022
@kilfoyle kilfoyle mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees
No one assigned
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.4.3 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sunilemanjee @elasticsearchmachine @kilfoyle @debadair @lcawl