Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index_.asciidoc #8973

Closed
wants to merge 1 commit into from
Closed

Update index_.asciidoc #8973

wants to merge 1 commit into from

Conversation

mausch
Copy link

@mausch mausch commented Dec 16, 2014

Map<String, Object> is actually poorly typed, can't represent JSON very well.

`Map<String, Object>` is actually poorly typed, can't represent JSON very well.
@clintongormley
Copy link

Hi @mausch

I'm not sure that this addition is helpful. It sounds more like a complaint than useful advice. Can you suggest a way of doing it better?

@mausch
Copy link
Author

mausch commented Dec 16, 2014

Hmm, my intention was only to amend the "very well" part. I know that people are used to represent JSON like that, and the Elasticsearch documentation is probably not the right place to teach people how to improve their usage of types.
A better way to represent JSON in Java is Gson

@kimchy
Copy link
Member

kimchy commented Dec 16, 2014

@clintongormley lets change the docs to remove the "very well" part, and its simply just another option that we provide, similar to XContentBuilder and using Jackson for example to serialize beans.

Also, we should change the example with Jackson to not have a "String" based example, as it will perform poorly, much better to work with bytes.

@dadoonet dadoonet self-assigned this Dec 16, 2014
@dadoonet dadoonet added >docs General docs changes :Core/Infra/Transport API Transport client API and removed feedback_needed labels Dec 16, 2014
@dadoonet dadoonet closed this in a50d82c Jan 2, 2015
dadoonet added a commit that referenced this pull request Jan 2, 2015
Closes #8973.

(cherry picked from commit a50d82c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Transport API Transport client API >docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants