Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to changelog processing after docs redesign #89463

Merged
merged 3 commits into from Aug 18, 2022

Conversation

pugnascotia
Copy link
Contributor

Closes #89441. We need to make some changes to our release documentation,
following a docs site redesign.

  1. Move the PR links in the release highlights. This one is trivial.
  2. Code blocks need to use the Asciidoc style, not the Markdown
    triple-backtick style. This is now enforced by the changelog
    validatation. I also backfilled the unit tests.

@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Aug 18, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Rory! LGTM.

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank!

@mark-vieira mark-vieira added v7.17.6 auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Aug 18, 2022
@mark-vieira mark-vieira merged commit f0df4b7 into elastic:main Aug 18, 2022
pugnascotia added a commit to pugnascotia/elasticsearch that referenced this pull request Aug 18, 2022
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.4
7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 89463

@mark-vieira
Copy link
Contributor

@pugnascotia I've noticed the release notes generation code has deviated a good amount between main and 7.17. Is this intentional? Should we get that synced up?

@mark-vieira
Copy link
Contributor

@debadair are these changes applicable to 7.17 patch releases as well?

@mark-vieira
Copy link
Contributor

@pugnascotia or is a lot of that stuff n/a for 7.17 since we aren't planning any new minors?

@pugnascotia
Copy link
Contributor Author

Uh...I don't really remember. I think we can use the same process for 7.17? In which case we should sync the generator code.

@pugnascotia pugnascotia deleted the 89441-docs-redesign-changes branch August 18, 2022 19:26
mark-vieira pushed a commit to mark-vieira/elasticsearch that referenced this pull request Aug 18, 2022
# Conflicts:
#	build-tools-internal/src/test/java/org/elasticsearch/gradle/internal/release/ReleaseHighlightsGeneratorTest.java
#	build-tools-internal/src/test/resources/org/elasticsearch/gradle/internal/release/ReleaseHighlightsGeneratorTest.generateFile.asciidoc
#	docs/changelog/83345.yaml
elasticsearchmachine pushed a commit that referenced this pull request Aug 19, 2022
# Conflicts:
#	build-tools-internal/src/test/java/org/elasticsearch/gradle/internal/release/ReleaseHighlightsGeneratorTest.java
#	build-tools-internal/src/test/resources/org/elasticsearch/gradle/internal/release/ReleaseHighlightsGeneratorTest.generateFile.asciidoc
#	docs/changelog/83345.yaml

Co-authored-by: Rory Hunter <pugnascotia@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Aug 19, 2022
* upstream/main: (265 commits)
  Disable openid connect tests due to missing fixture (elastic#89478)
  Add periodic job for single processor node testing
  Updates to changelog processing after docs redesign (elastic#89463)
  Better support for multi cluster for run task (elastic#89442)
  Mute failing tests (elastic#89465)
  [ML] Performance improvements related to ECS Grok pattern usage (elastic#89424)
  Add source fallback support for date and date_nanos mapped types (elastic#89440)
  Reuse Info in lifecycle step (elastic#89419)
  feature: support metrics for multi value fields (elastic#88818)
  Upgrade OpenTelemetry API and remove workaround (elastic#89438)
  Remove LegacyClusterTaskResultActionListener (elastic#89459)
  Add YAML spec docs about matching errors (elastic#89370)
  Remove redundant cluster upgrade tests for auth tokens (elastic#89417)
  Return 400 error for GetUserPrivileges call with API keys (elastic#89333)
  User Profile - Detailed errors in hasPrivileges response (elastic#89224)
  Rollover min_* conditions docs and highlight (elastic#89434)
  REST tests for percentiles_bucket agg (elastic#88029)
  REST tests for cumulative pipeline aggs (elastic#88966)
  Clean-up file watcher keys. (elastic#89429)
  fix a typo in Security.java (elastic#89248)
  ...

# Conflicts:
#	server/src/main/java/org/elasticsearch/index/mapper/NumberFieldMapper.java
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :Delivery/Tooling Developer tooliing and automation >enhancement Team:Delivery Meta label for Delivery team v7.17.6 v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Release highlights have broken heading links & no code highlighting
4 participants