Unify handling of custom Gradle User home in build tool tests #89304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
|
Should reduce risk of running into #89285 |
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
force-pushed
the
handle-custom-guh-in-tests
branch
2 times, most recently
from
fb1c89e
to
cbf3f5f
Compare
- keep guh separated from test project dir - unify folder handling
breskeby
force-pushed
the
handle-custom-guh-in-tests
branch
from
cbf3f5f
to
7e7d0c9
Compare
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 17, 2022
…c#89304) - keep guh separated from test project dir - unify folder handling as a side effect when keeping the project dir for debugging failed tests we do not copy the whole GUH which usually isn't providing any additional help for debugging those # Conflicts: # build-tools/src/testFixtures/groovy/org/elasticsearch/gradle/fixtures/AbstractGradleFuncTest.groovy
jan0sch
pushed a commit
to wegtam/elasticsearch
that referenced
this pull request
Aug 18, 2022
…c#89304) (elastic#89402) Backports the following commits to 7.17: - Unify handling of custom Gradle User home in build tool tests (elastic#89304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as a side effect when keeping the project dir for debugging failed tests we do not copy the whole GUH which usually isn't providing any additional help for debugging those