Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve BWC distribution mismatch error message #88911

Merged
merged 4 commits into from Aug 22, 2022
Merged

Improve BWC distribution mismatch error message #88911

merged 4 commits into from Aug 22, 2022

Conversation

mark-vieira
Copy link
Contributor

After version bumps, it's very common for open PR branches to start failing because of the missing version constants breaking BWC distribution assumptions. You end up getting somewhat obscure error that doesn't give you much indication as to the reason things failed:

* What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Building 8.3.3 didn't generate expected artifact /dev/shm/elastic+elasticsearch+pull-request+bwc/distribution/bwc/bugfix/build/bwc/checkout-8.3/distribution/archives/linux-tar/build/install/elasticsearch-8.3.3-SNAPSHOT

This PR amends this error message to give developers some hint as to what might be wrong:

* What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Building 8.3.3 didn't generate expected artifact [distribution/bwc/bugfix/build/bwc/checkout-8.3/distribution/archives/linux-tar/build/install/elasticsearch-8.3.3-SNAPSHOT]. The working branch may be out of date.

@mark-vieira mark-vieira added >non-issue :Delivery/Build Build or test infrastructure auto-backport-and-merge Automatically create backport pull requests and merge when ready v7.17.6 v8.4.1 labels Jul 28, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine added the Team:Delivery Meta label for Delivery team label Jul 28, 2022
@mark-vieira
Copy link
Contributor Author

@elasticmachine update branch

@mark-vieira mark-vieira merged commit 5b999ee into elastic:main Aug 22, 2022
@mark-vieira mark-vieira deleted the bwc_error_messages branch August 22, 2022 17:01
@mark-vieira mark-vieira mentioned this pull request Aug 22, 2022
Merged
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Aug 22, 2022
@mark-vieira
Improve BWC distribution mismatch error message (elastic#88911)
f5564e4
@mark-vieira mark-vieira mentioned this pull request Aug 22, 2022
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 7.17
✅ 8.4

mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Aug 22, 2022
@mark-vieira
Improve BWC distribution mismatch error message (elastic#88911)
5c28a51
elasticsearchmachine pushed a commit that referenced this pull request Aug 22, 2022
@mark-vieira
Improve BWC distribution mismatch error message (#88911) (#89515)
6a7beb9
elasticsearchmachine pushed a commit that referenced this pull request Aug 22, 2022
@mark-vieira
Improve BWC distribution mismatch error message (#88911) (#89514)
da63175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pugnascotia pugnascotia pugnascotia approved these changes

@breskeby breskeby Awaiting requested review from breskeby

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.17.6 v8.4.1 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mark-vieira @elasticsearchmachine @pugnascotia @elasticmachine