Remove failing test which mocked now sealed InetAddress class #86490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slobodanadamovic
added
>test-failure
|
Pinging @elastic/es-security (Team:Security) |
tvernum
approved these changes
May 9, 2022
slobodanadamovic
added a commit
to slobodanadamovic/elasticsearch
that referenced
this pull request
Aug 22, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
testIsAnyLocalAddressbecauseInetAddressclass cannot be mocked anymore (well not without enabling experimental mockito plugin). The class is marked as sealed in Java 19.testIsAnyLocalAddresswas simply testing ifInetAddress#isAnyLocalAddressmethod was the only one called. Since this test is not adding particular value, I think removal is justified.Closes #86418