[Test] More robust comparison for OIDC URLs #86374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The String representation of OIDC url is not stable because the query parameters can be different orders (underlying backed by a HashMap). This PR improves the robustness of URL comparison by comparing the parsed query parameters instead of the non-stable serialised string form. Resolves: elastic#86291
ywangd
added
>test
|
Pinging @elastic/es-security (Team:Security) |
|
@elasticmachine update branch |
ywangd
added
the
auto-merge
|
@elasticmachine run elasticsearch-ci/part-2 |
This was referenced Aug 17, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The String representation of OIDC url is not stable because the query
parameters can be different orders (underlying backed by a HashMap).
This PR improves the robustness of URL comparison by comparing the
parsed query parameters instead of the non-stable serialised string
form.
Resolves: #86291