EQL: Fix join keys ordering in a sequence #76699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A sequence payload is constructed by providing one list of sequences and one for the hits. When fetching the list of hits though, the list of sequnces can be iterated in reverse order to build the hit references; meaning that the original list of sequences provided to the sequence payload needs reversing too.
elasticmachine
added
the
Team:QL (Deprecated)
|
Pinging @elastic/es-ql (Team:QL) |
Luegg
approved these changes
Aug 23, 2021
bpintea
added
the
auto-backport-and-merge
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and one for the hits. When fetching the list of hits though, the list of sequnces can be iterated in reverse order to build the hit references; meaning that the original list of sequences provided to the sequence payload needs reversing too.
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and one for the hits. When fetching the list of hits though, the list of sequnces can be iterated in reverse order to build the hit references; meaning that the original list of sequences provided to the sequence payload needs reversing too.
bpintea
added a commit
to bpintea/elasticsearch
that referenced
this pull request
Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and one for the hits. When fetching the list of hits though, the list of sequnces can be iterated in reverse order to build the hit references; meaning that the original list of sequences provided to the sequence payload needs reversing too.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and one for the hits. When fetching the list of hits though, the list of sequnces can be iterated in reverse order to build the hit references; meaning that the original list of sequences provided to the sequence payload needs reversing too.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and one for the hits. When fetching the list of hits though, the list of sequnces can be iterated in reverse order to build the hit references; meaning that the original list of sequences provided to the sequence payload needs reversing too.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 25, 2021
A sequence payload is constructed by providing one list of sequences and one for the hits. When fetching the list of hits though, the list of sequnces can be iterated in reverse order to build the hit references; meaning that the original list of sequences provided to the sequence payload needs reversing too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sequence payload is constructed by providing a list of sequences and
a list of corresponding hits. When fetching the list of hits though, the list of
sequences can be iterated in reverse order to build the hit references;
meaning that the original list of sequences provided to the sequence
payload needs reversing too, as the join keys will be extracted from it.
Fixes #76209.