Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running all EQL BWC tasks when running check #75743

Merged
merged 1 commit into from Jul 28, 2021

Conversation

mark-vieira
Copy link
Contributor

The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.

The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.
@mark-vieira mark-vieira added >non-issue :Delivery/Build Build or test infrastructure auto-backport Automatically create backport pull requests when merged v7.14.1 v7.15.0 v7.13.5 labels Jul 27, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Jul 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@mark-vieira
Copy link
Contributor Author

You can see in this build scan we are running all index compatible version tests when running the check task which is incorrect. The check task should only include unreleased versions, otherwise over time our builds would just get increasingly slower and slower. For released versions this is what our CI matrix suite is for.

https://gradle-enterprise.elastic.co/s/qa5ur5fasjcxu/timeline?task-path=eql:qa:mixed-node&type=org.elasticsearch.gradle.testclusters.StandaloneRestIntegTestTask

@mark-vieira
Copy link
Contributor Author

@astefan it looks like #68802 was never reviewed before being merged. As a point of process going forward please add someone from the delivery team to review any PRs that include substantial build-related changes such as adding new BWC test suites. It's super easy to shoot yourself in the foot with this sort of stuff 😉

@astefan
Copy link
Contributor

astefan commented Jul 28, 2021

@mark-vieira that PR is made of three other PRs and all of them were approved, as mentioned in the PR description.

@astefan
Copy link
Contributor

astefan commented Jul 28, 2021

Regarding the usage of check, the relevant PR - #68602 - that needs this added logic, checks the behavior of the current version against nodes of older versions in a mixed node cluster. This is, indeed, about bwc but is also relevant when new PRs are added to QL.

@mark-vieira When running CI jobs for new PRs, is mixedClusterTest series of tasks executed as well?

@mark-vieira
Copy link
Contributor Author

@mark-vieira When running CI jobs for new PRs, is mixedClusterTest series of tasks executed as well?

Yes, but only against snapshot versions. We don't run BWC tests against every compatible released version because it would prohibitively costly to so.

@mark-vieira
Copy link
Contributor Author

As you can see from the build scan for this pull request, we run the EQL mixed cluster tests, but only against 7.15.

https://gradle-enterprise.elastic.co/s/oagspdqk7fkye/tests?search=eql

We then have a separate periodic CI job that runs the full set of versions.

https://elasticsearch-ci.elastic.co/view/Elasticsearch%20master/job/elastic+elasticsearch+master+periodic+bwc/

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-vieira mark-vieira merged commit 8211fa6 into elastic:master Jul 28, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 28, 2021
The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 28, 2021
The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 28, 2021
The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.13
7.14
7.x

elasticsearchmachine added a commit that referenced this pull request Jul 28, 2021
The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.

Co-authored-by: Mark Vieira <portugee@gmail.com>
elasticsearchmachine added a commit that referenced this pull request Jul 28, 2021
The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.

Co-authored-by: Mark Vieira <portugee@gmail.com>
@mark-vieira mark-vieira deleted the eql_bwc_test_tasks branch July 28, 2021 16:59
elasticsearchmachine added a commit that referenced this pull request Jul 28, 2021
The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.

Co-authored-by: Mark Vieira <portugee@gmail.com>
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.13.5 v7.14.0 v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants