Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.8] OsStats must be lenient with bad data from older nodes #73616

Merged
merged 2 commits into from Jun 1, 2021

Conversation

williamrandolph
Copy link
Contributor

We've had a series of bug fixes for cases where an OsProbe gives negative values, most often just -1, to the OsStats class. We added assertions to catch cases where we were initializing OsStats with bad values. Unfortunately, these fixes turned to not be backwards-compatible. In this commit, we simply coerce bad values to 0 when data is coming from nodes that don't have the relevant bug fixes.

Relevant PRs:

Fixes #73459

Backport of #73610

@williamrandolph williamrandolph added >test Issues or PRs that are addressing/adding tests backport v6.8.17 labels Jun 1, 2021
@williamrandolph williamrandolph changed the title OsStats must be lenient with bad data from older nodes [6.8] OsStats must be lenient with bad data from older nodes Jun 1, 2021
@williamrandolph williamrandolph merged commit 38cbf10 into elastic:6.8 Jun 1, 2021
@williamrandolph williamrandolph deleted the fix/6.8/os-stats-bwc branch May 23, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >test Issues or PRs that are addressing/adding tests v6.8.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant