-
Notifications
You must be signed in to change notification settings - Fork 25.2k
ReindexIT wait for task to really start #73018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
henningandersen
merged 3 commits into
elastic:master
from
henningandersen:test_fix_reindex_it
Jul 1, 2021
Merged
ReindexIT wait for task to really start #73018
henningandersen
merged 3 commits into
elastic:master
from
henningandersen:test_fix_reindex_it
Jul 1, 2021
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reindex and friends have tasks that start but are not ready to rethrottle before they figured out if they are leader or worker tasks. Now wait for the task to fully start before rethrottling. Also added additional assertions to help see if the inability to rethrottle is caused by some failure. Closes elastic#60811
Pinging @elastic/es-distributed (Team:Distributed) |
@elasticmachine run elasticsearch-ci/packaging-tests-unix-sample |
Tim-Brooks
approved these changes
Jun 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
henningandersen
added a commit
that referenced
this pull request
Jul 1, 2021
Reindex and friends have tasks that start but are not ready to rethrottle before they figured out if they are leader or worker tasks. Now wait for the task to fully start before rethrottling. Also added additional assertions to help see if the inability to rethrottle is caused by some failure. Closes #60811
henningandersen
added a commit
that referenced
this pull request
Jul 1, 2021
Reindex and friends have tasks that start but are not ready to rethrottle before they figured out if they are leader or worker tasks. Now wait for the task to fully start before rethrottling. Also added additional assertions to help see if the inability to rethrottle is caused by some failure. Closes #60811
henningandersen
added a commit
that referenced
this pull request
Jul 1, 2021
Reindex and friends have tasks that start but are not ready to rethrottle before they figured out if they are leader or worker tasks. Now wait for the task to fully start before rethrottling. Also added additional assertions to help see if the inability to rethrottle is caused by some failure. Closes #60811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/Reindex
Issues relating to reindex that are not caused by issues further down
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
>test
Issues or PRs that are addressing/adding tests
v7.13.4
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reindex and friends have tasks that start but are not ready to
rethrottle before they figured out if they are leader or worker
tasks. Now wait for the task to fully start before rethrottling.
Also added additional assertions to help see if the inability
to rethrottle is caused by some failure.
Closes #60811