Remove race in ensure remote connection test #72961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently RemoteClusterConnectionTests#testEnsureConnected uses the same countdown latch for two ensure connected method calls. This introduces a race where the test ends before the second ensure connected method executes. This causes an exception to be thrown and the test to fail. This commit resolves the issue by adding a second latch. Fixes elastic#71519.
Tim-Brooks
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently RemoteClusterConnectionTests#testEnsureConnected uses the same
countdown latch for two ensure connected method calls. This introduces a
race where the test ends before the second ensure connected method
executes. This causes an exception to be thrown and the test to fail.
This commit resolves the issue by adding a second latch.
Fixes #71519.