Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: make RestSqlQueryAction thread-safe #69895

Merged
merged 2 commits into from Mar 3, 2021
Merged

SQL: make RestSqlQueryAction thread-safe #69895

merged 2 commits into from Mar 3, 2021

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Mar 3, 2021

Remove TextFormat as instance variable from RestSqlQueryAction.
Fixes #69866.

@elasticmachine elasticmachine added the Team:QL (Deprecated) Meta label for query languages team label Mar 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

matriv
matriv approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv mentioned this pull request Mar 3, 2021
Closed
@astefan astefan requested review from costin and palesz March 3, 2021 16:22
costin
costin approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for the fast turn-around.

@astefan astefan mentioned this pull request Mar 3, 2021
Merged
@astefan astefan merged commit 20f9397 into elastic:7.x Mar 3, 2021
@astefan astefan deleted the 69866_fix branch March 3, 2021 17:25
astefan added a commit to astefan/elasticsearch that referenced this pull request Mar 3, 2021
@astefan
Remove TextFormat as an instance variable (elastic#69895)
caa5b4f 
(cherry picked from commit 20f9397)
astefan added a commit to astefan/elasticsearch that referenced this pull request Mar 3, 2021
@astefan
Remove TextFormat as an instance variable (elastic#69895)
77ac0e5 
(cherry picked from commit 20f9397)
astefan added a commit that referenced this pull request Mar 3, 2021
@astefan
Remove TextFormat as an instance variable (#69895) (#69911)
53d584c 
(cherry picked from commit 20f9397)
astefan added a commit that referenced this pull request Mar 3, 2021
@astefan
Remove TextFormat as an instance variable (#69895) (#69912)
68ff7ca 
(cherry picked from commit 20f9397)
@astefan astefan mentioned this pull request Mar 3, 2021
Closed
astefan added a commit to astefan/elasticsearch that referenced this pull request Mar 4, 2021
@astefan
Remove TextFormat as an instance variable (elastic#69895)
18036e4 
(cherry picked from commit 20f9397)
This was referenced Mar 11, 2021
Closed
Closed
Merged
Merged
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

@matriv matriv matriv approved these changes

@palesz palesz Awaiting requested review from palesz

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug Team:QL (Deprecated) Meta label for query languages team v7.11.2 v7.12.0 v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@astefan @elasticmachine @costin @matriv