Show -Dlicense.key value in test repro info #66179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
rjernst
reviewed
Dec 10, 2020
| @@ -181,10 +182,32 @@ private ReproduceErrorMessageBuilder appendESProperties() { | |||
| appendOpt("tests.timezone", TimeZone.getDefault().getID()); | |||
| appendOpt("tests.distribution", System.getProperty("tests.distribution")); | |||
| appendOpt("runtime.java", Integer.toString(JavaVersion.current().getVersion().get(0))); | |||
| appendOpt("runtime.java", Integer.toString(JavaVersion.current().getVersion().get(0))); | |||
There was a problem hiding this comment.
This line seems to be duplicated?
| appendOpt(ESTestCase.FIPS_SYSPROP, System.getProperty(ESTestCase.FIPS_SYSPROP)); | ||
| return this; | ||
| } | ||
|
|
||
| private String relativePath(String pathProperty) { |
There was a problem hiding this comment.
Is this necessary once the fix is made in xpack to use Gradle's file resolution to get the path relative to the root project? With that change, and using a relative path in CI, shouldn't the reproduction line should just work for devs copying it from CI to their machines?
There was a problem hiding this comment.
This also works with having an absolute path passed in the commandline (e.g.on ci)
There was a problem hiding this comment.
But it will not required if we ensure we always pass a relative path here only
There was a problem hiding this comment.
I'm just wondering if is necessary at all. It is specifically for CI. If a developer passes an absolute path, it will still work. We just need to ensure we pass a relative path in CI.
There was a problem hiding this comment.
in that case I can remove this
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
breskeby
force-pushed
the
consider-license-sysprop-in-repro-printer
branch
from
85ce4ce
to
70a72aa
Compare
chengyang14
pushed a commit
to chengyang14/elasticsearch
that referenced
this pull request
Dec 14, 2020
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - Absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
talevy
pushed a commit
to talevy/elasticsearch
that referenced
this pull request
Dec 14, 2020
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - Absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
alyokaz
pushed a commit
to alyokaz/elasticsearch
that referenced
this pull request
Mar 10, 2021
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - Absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 17, 2022
- When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - Absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this in the test reproduction info message
root to allow simply copy & paste