Give more time to AutoFollowIT tests #51938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
|
Pinging @elastic/es-distributed (:Distributed/CCR) |
|
Thanks Nhat! |
tlrx
added a commit
that referenced
this pull request
Feb 5, 2020
AutoFollowIT tests are regularly failing on CI because they rely on how cluster state updates are processed within the integration clusters. We tried to limit this in #49141 by moving to latches instead of waiting for assertions to pass but there are still some places were it still need to wait for the cluster state updates to be processed and auto-follow stats to be updated. This commit gives more time to assertBusy() that verifies the AutoFollowStats (up to 60 seconds) and also always log the auto-follow stats in case the assertions failed. Closes #48982
tlrx
added a commit
that referenced
this pull request
Feb 5, 2020
AutoFollowIT tests are regularly failing on CI because they rely on how cluster state updates are processed within the integration clusters. We tried to limit this in #49141 by moving to latches instead of waiting for assertions to pass but there are still some places were it still need to wait for the cluster state updates to be processed and auto-follow stats to be updated. This commit gives more time to assertBusy() that verifies the AutoFollowStats (up to 60 seconds) and also always log the auto-follow stats in case the assertions failed. Closes #48982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoFollowIT tests are regularly failing on CI because they rely on how cluster state updates are processed within the integration clusters. We tried to limit this in #49141 by moving to latches instead of waiting for assertions to pass but there are still some places were it still need to wait for the cluster state updates to be processed and auto-follow stats to be updated.
This PR gives more time to
assertBusy()that verifies the AutoFollowStats (up to 60 seconds) and also always log the auto-follow stats in case the assertions failed.Closes #48982