Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: QueryBuilder dependency #107911

Open
craigtaverner opened this issue Apr 25, 2024 · 1 comment
Open

ESQL: QueryBuilder dependency #107911

craigtaverner opened this issue Apr 25, 2024 · 1 comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt

Comments

@craigtaverner
Copy link
Contributor

When developing lucene push-down optimizations within ES|QL we often need to make use of QueryBuilders, sometimes just using the existing ones in Elasticsearch, sometimes creating custom QueryBuilder implementations (like we did for spatial search in ST_INTERSECTS). But ES|QL does not need the full bells and whistles of Elasticsearch QueryBuilder. There are two concerns:

  • Using existing QueryBuilder implementations connects us to implementations that have quite different purposes
  • Creating custom QueryBuilder classes involves having to implement a bunch of methods that do nothing, which looks quite ugly

A first attempt to break this dependency was blocked by apparent needs for QueryBuilder in the QL code-base. Since we're decoupling ES|QL from the rest of QL, once that is done, this work should become much easier.

@craigtaverner craigtaverner added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt :Analytics/ES|QL AKA ESQL labels Apr 25, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >tech debt
Projects
None yet
Development

No branches or pull requests

2 participants