From 6002a5e45645e3446a0ab6ea8988045d5643d7bc Mon Sep 17 00:00:00 2001 From: Rene Groeschke Date: Wed, 17 Aug 2022 09:47:54 +0200 Subject: [PATCH] Show -Dlicense.key value in test repro info (#66179) (#89404) - When a -Dlicense.key sys property is passed to the build we want to consider this in the test reproduction info message - Absolute Paths tried to be converted to relative paths relative to workspace root to allow simply copy & paste - Also fixes a inconsistency for checking license existence in x-pack plugin core build --- .../test/junit/listeners/ReproduceInfoPrinter.java | 2 +- x-pack/plugin/core/build.gradle | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/test/framework/src/main/java/org/elasticsearch/test/junit/listeners/ReproduceInfoPrinter.java b/test/framework/src/main/java/org/elasticsearch/test/junit/listeners/ReproduceInfoPrinter.java index 99b2840c3c0d8..024eb08094e2c 100644 --- a/test/framework/src/main/java/org/elasticsearch/test/junit/listeners/ReproduceInfoPrinter.java +++ b/test/framework/src/main/java/org/elasticsearch/test/junit/listeners/ReproduceInfoPrinter.java @@ -89,7 +89,6 @@ public void testFailure(Failure failure) throws Exception { } } b.append("\""); - GradleMessageBuilder gradleMessageBuilder = new GradleMessageBuilder(b); gradleMessageBuilder.appendAllOpts(failure.getDescription()); @@ -171,6 +170,7 @@ private ReproduceErrorMessageBuilder appendESProperties() { appendOpt("tests.timezone", TimeZone.getDefault().getID()); appendOpt("tests.distribution", System.getProperty("tests.distribution")); appendOpt("runtime.java", Integer.toString(JavaVersion.current().getVersion().get(0))); + appendOpt("license.key", System.getProperty("licence.key")); appendOpt(ESTestCase.FIPS_SYSPROP, System.getProperty(ESTestCase.FIPS_SYSPROP)); return this; } diff --git a/x-pack/plugin/core/build.gradle b/x-pack/plugin/core/build.gradle index 3daffdec44d3b..0d27feab8bcfe 100644 --- a/x-pack/plugin/core/build.gradle +++ b/x-pack/plugin/core/build.gradle @@ -86,10 +86,11 @@ tasks.named("processResources").configure { } else { throw new IllegalArgumentException('Property license.key must be set for release build') } - if (Files.exists(Paths.get(licenseKey)) == false) { + File licenseKeyFile = rootProject.file(licenseKey) + if (licenseKeyFile.exists() == false) { throw new IllegalArgumentException('license.key at specified path [' + licenseKey + '] does not exist') } - from(licenseKey) { + from(licenseKeyFile) { rename { String filename -> 'public.key' } } }