Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Migration to tokio 1.0 #152

Closed
krojew opened this issue Oct 19, 2020 · 6 comments · Fixed by #158
Closed

[ENHANCEMENT] Migration to tokio 1.0 #152

krojew opened this issue Oct 19, 2020 · 6 comments · Fixed by #158
Labels
enhancement New feature or request

Comments

@krojew
Copy link
Contributor

krojew commented Oct 19, 2020

Is your feature request related to a problem? Please describe.
Since tokio 0.3 was released, it would be great to migrate, otherwise it's necessary to wrap each future in a compatibility layer.

Describe the solution you'd like
Migration to tokio 0.3. Any dependencies can be wrapped in a compatibility layer until they get updated too.

Describe alternatives you've considered
tokio-compat-02 crate.

Additional context
https://tokio.rs/blog/2020-10-tokio-0-3

EDIT: Should now update to tokio 1.0

@krojew krojew added the enhancement New feature or request label Oct 19, 2020
@fteychene
Copy link

fteychene commented Nov 20, 2020

I tried to upgrade to tokio 0.3 and updated the code to make it build on a local branch.

The main struggle point on this migration is that we use hyper servers during tests runtime and reqwest for calling servers.
Theses two libs still doesn't migrated to tokio 0.3 ATM.

Hyper server is failing because wanting to get the current Handle with tokio 2 that is not populated with tokio 3 and reqwest use hyper under the hood.

Hyper migrated to tokio 3 in their master 0.14 dev branch, we just need to wait their migrations.

@russcam
Copy link
Contributor

russcam commented Dec 2, 2020

Thanks for the investigation, @fteychene - sounds like we need to wait for the moment. Would be happy to accept a PR for the migration, once it's possible.

@krojew krojew changed the title [ENHANCEMENT] Migration to tokio 0.3 [ENHANCEMENT] Migration to tokio 1.0 Dec 30, 2020
@krojew
Copy link
Contributor Author

krojew commented Dec 30, 2020

reqwest got updated to tokio 1.0. It would be nice to update here, when they publish new crate.

@swallez
Copy link
Member

swallez commented Jan 4, 2021

@krojew we need support of Tokio 1.0 in reqwest. Indeed this has been merged but not yet included in a released.

@swallez
Copy link
Member

swallez commented Jan 5, 2021

And here it is, reqwest 0.11.0 was just released, based on Tokio 1.0. We can work on the migration.

@Jasperav
Copy link

Any update on the migration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants