Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field_masking_span is deprecated in ES8.0+ but still used in java client #809

Closed
vdemay opened this issue May 16, 2024 · 4 comments
Closed
Labels
Area: Specification Related to the API spec used to generate client code Category: Bug Something isn't working

Comments

@vdemay
Copy link

vdemay commented May 16, 2024

Java API client version

8.13.4

Java version

11

Elasticsearch Version

8.13.4

Problem description

Hello,

Since ES8.0 field_masking_span is deprecated in favor of span_field_masking. Ref: https://github.com/elastic/elasticsearch/pull/74718/files

This change is not reflected to elasticsearch-java client causing exception on ES: deprecated fields not supported here but got [field_masking_span] which has been replaced with [span_field_masking]

I've made this PR to propose a fix. (I signed the agreement right after creating the PR making the validation failed - sorry about that :) )

Thanks for your help

@l-trotta
Copy link
Contributor

Hello, thank you for reporting this! Unfortunately we cannot accept PRs in this repo since the java client is 99% autogenerated from our api-specification. If you want you can contribute there to fix the issue for all clients :D otherwise we'll do it. Thanks!

@l-trotta l-trotta added Area: Specification Related to the API spec used to generate client code Category: Bug Something isn't working labels May 17, 2024
@vdemay
Copy link
Author

vdemay commented May 17, 2024

Hello, thanks for your answer. I'll do

@vdemay
Copy link
Author

vdemay commented May 17, 2024

You can find the new PR in api-specification project

Thanks for your help!

@l-trotta
Copy link
Contributor

Thanks again for providing a fix! Closing this as it will be part of the next minor release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Specification Related to the API spec used to generate client code Category: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants