Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting deprecation warnings from es as they are preparing for next release #1551

Closed
blessyxavier opened this issue Dec 9, 2021 · 5 comments

Comments

@blessyxavier
Copy link

We are using the latest version(7.4.0) of elasticsearch-dsl in our python project. But we are getting deprecation warnings from es saying

elasticsearch_dsl/index.py:279: DeprecationWarning: The 'body' parameter is deprecated for the 'create' API and will be removed in a future version. Instead use API parameters directly. See elastic/elasticsearch-py#1698 for more information
return self.get_connection(using).indices.create(

Can you give some update about your future releases? Will this deprecation warning be gone with your upcoming release?

@sethmlarson
Copy link
Contributor

Closed in #1642, available in v7.4.1 on PyPI.

@sarayourfriend
Copy link

@sethmlarson Should this issue be re-opened? This commit (and line, specifically) cause deprecation warnings to appear again:

https://github.com/elastic/elasticsearch-dsl-py/pull/1664/files#diff-a051cc028fe71537806a081bbae62c89853cc5fe07c239019b78d5a371581825R712

I can open a new issue, if you'd prefer.

@pquentin
Copy link
Member

pquentin commented Sep 15, 2023

Hey @sarayourfriend, I'm the new maintainer of the Elasticsearch Python clients, and would like to apologize for that.

Since we have decided to un-deprecate the body parameter (elastic/elasticsearch-py#2181), I thought that releasing version 8.x of the DSL client was more important than the warning, but it would have been better to do this the other way around. Please follow that issue for news about the deprecation removal.

@sarayourfriend
Copy link

Aha! Thanks for the information 🙏

@pquentin
Copy link
Member

@sarayourfriend elasticsearch-py 8.10.1 removed the deprecation warning: https://github.com/elastic/elasticsearch-py/releases/tag/v8.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants