Update default stack version to 8.6.1 #1118
Merged
+40
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
/test |
|
/test |
mrodm
approved these changes
Jan 27, 2023
Comment on lines
128
to
129
| start_period: 60s | ||
| retries: 360 |
There was a problem hiding this comment.
Even using these settings, there are some cases where elastic_agent_is_ready container still has unhealthy status 😞
ERROR: for elastic-agent_is_ready Container "066fd24a8fc6" is unhealthy.
Not sure if at least those will help us to make it a bit better
I've not been able to reproduce it locally to check what it is the output of the healthchecks using docker inspect
|
/test |
mrodm
approved these changes
Jan 27, 2023
|
/test |
1 similar comment
|
/test |
|
/test |
|
/test |
|
/test |
|
/test |
mrodm
approved these changes
Jan 30, 2023
Comment on lines
+69
to
+72
| if onlyElasticAgentFailed() { | ||
| fmt.Println("Elastic Agent failed to start, trying again.") | ||
| err = dockerComposeUp(options) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add also some options to try to reduce flakiness in
elastic-package stack up: