Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce transitive dependencies from sentence-transformers #624

Open
joshdevins opened this issue Oct 19, 2023 · 0 comments
Open

Reduce transitive dependencies from sentence-transformers #624

joshdevins opened this issue Oct 19, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers topic:NLP Issue or PR about NLP model support and eland_import_hub_model

Comments

@joshdevins
Copy link
Member

joshdevins commented Oct 19, 2023 •
edited

When we install sentence-transformers in our pytorch target, we pull in all of the transitive dependencies of that library which include many libraries that we will never need. Excluding these transitive dependencies will reduce eland's overall installation footprint and consequently the Docker image size. This simplification can also help reduce dependency conflicts such as #408.

'tqdm',
'torchvision',
'numpy',
'scikit-learn',
'scipy',
'nltk',
@joshdevins joshdevins added enhancement New feature or request good first issue Good for newcomers topic:NLP Issue or PR about NLP model support and eland_import_hub_model labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers topic:NLP Issue or PR about NLP model support and eland_import_hub_model
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshdevins