Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject package deprecated in controller-runtime 0.10.0 #4220

Closed
charith-elastic opened this issue Feb 8, 2021 · 3 comments
Closed

Inject package deprecated in controller-runtime 0.10.0 #4220

charith-elastic opened this issue Feb 8, 2021 · 3 comments

Comments

@charith-elastic
Copy link
Contributor

The inject package is planned for removal in controller-runtime 0.10.0. AFAICT, there's no issue other than this comment and PR.

We only use the inject package directly in dynamic watches. There is no need to use inject there because none of the watch types we use in our code implement inject.Scheme or inject.Mapper anyway.

Unfortunately, controller-runtime still uses the deprecated methods internally and causes a series of warning log message to be output when the operator starts up.

INFO	controller-runtime.injectors-warning	Injectors are deprecated, and will be removed in v0.10.x

There's nothing much we can do to avoid this other than wait for a controller-runtime update.

@charith-elastic
Copy link
Contributor Author

The log message is getting reverted in kubernetes-sigs/controller-runtime#1382.

@charith-elastic
Copy link
Contributor Author

Issue to track the deprecation effort: kubernetes-sigs/controller-runtime#1433

@pebrc
Copy link
Collaborator

pebrc commented Jun 8, 2022

The effort to deprecated inject has stalled. I am closing this issue for now we can reopen when this gains traction again.

@pebrc pebrc closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants