Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreUrls and transactionIgnoreUrls match against req.url, it should match only the pathname #3667

Open
trentm opened this issue Oct 13, 2023 · 0 comments
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Oct 13, 2023

With an APM agent configured with:

  transactionIgnoreUrls: ['/robots.txt']

will ignore an incoming GET /robots.txt request, but not an incoming GET /robots.txt?query.

The matching code (shouldIgnoreRequest in "http-shared.js") is matching with req.url. We will need to (carefully) parse the req.url to get just the pathname to match against.
The spec is clear with a specific http://whatever.com/home/index?value1=123 example.

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

No branches or pull requests

1 participant