Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up modelwriter #888

Merged
merged 1 commit into from Feb 1, 2021
Merged

Tidy up modelwriter #888

merged 1 commit into from Feb 1, 2021

Conversation

axw
Copy link
Member

@axw axw commented Feb 1, 2021

Some light refactoring to move "context" model building
logic out of modelwriter and into the Context.build method.

There remains some context model building in modelwriter
(related to setting destination service type) because it
requires additional information outside of "context", i.e.
the span type.

Some light refactoring to move "context" model building
logic out of modelwriter and into the Context.build method.
There remains some context model building in modelwriter
(related to setting destination service type) because it
requires additional information outside of "context", i.e.
the span type.
@codecov-io
Copy link

Codecov Report

Merging #888 (496de29) into master (697d794) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #888   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files         142      142           
  Lines        7959     7960    +1     
=======================================
+ Hits         6662     6663    +1     
  Misses        889      889           
  Partials      408      408           
Impacted Files Coverage Δ
modelwriter.go 96.62% <ø> (-0.12%) ⬇️
context.go 94.84% <100.00%> (+0.28%) ⬆️
error.go 95.18% <100.00%> (+0.01%) ⬆️
transaction.go 94.02% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697d794...496de29. Read the comment docs.

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #888 opened

    • Start Time: 2021-02-01T03:40:20.571+0000
  • Duration: 27 min 24 sec

  • Commit: 496de29

Test stats 🧪

Test Results
Failed 0
Passed 7676
Skipped 188
Total 7864

@axw axw requested a review from a team February 1, 2021 05:05
@axw axw merged commit dd3e8c5 into elastic:master Feb 1, 2021
@axw axw deleted the sanitize-context branch February 1, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants