Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/apmlog: fix log levels #860

Merged
merged 1 commit into from Dec 14, 2020
Merged

Conversation

axw
Copy link
Member

@axw axw commented Dec 14, 2020

  • Add the "trace" level.
  • In addition to "warn", we should also accept "warning".

See the spec: https://github.com/elastic/apm/blob/master/specs/agents/logging.md

(Thanks @trentm!)

- Add the "trace" level.
- In addition to "warn", we should also accept "warning".
@axw axw requested a review from a team December 14, 2020 02:47
@codecov-io
Copy link

Codecov Report

Merging #860 (6b53652) into master (491755f) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   83.77%   83.71%   -0.06%     
==========================================
  Files         142      142              
  Lines        7913     7921       +8     
==========================================
+ Hits         6629     6631       +2     
- Misses        876      883       +7     
+ Partials      408      407       -1     
Impacted Files Coverage Δ
internal/apmlog/logger.go 72.83% <0.00%> (-7.99%) ⬇️
tracer.go 89.06% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491755f...6b53652. Read the comment docs.

@apmmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #860 opened

  • Start Time: 2020-12-14T02:47:33.454+0000

  • Duration: 24 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 7663
Skipped 188
Total 7851

@axw axw merged commit 0a73d5b into elastic:master Dec 14, 2020
@axw axw deleted the apmlog-fix-levels branch December 14, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants