Transaction.Discard sets TransactionData to nil #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Transaction.Discard so that it sets TransactionData to nil, like its documentation says. This is necessary to avoid Transaction.End from enqueuing a transaction after it has been discarded.
axw
force-pushed
the
transation-discard-niltransactiondata
branch
from
e526943
to
a74dd31
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
jalvz
approved these changes
Oct 20, 2020
jalvz
reviewed
Oct 20, 2020
| @@ -35,6 +35,7 @@ https://github.com/elastic/apm-agent-go/compare/v1.8.0...master[View commits] | |||
| - Add cloud metadata, configurable with ELASTIC_APM_CLOUD_PROVIDER {pull}823[#(823)] | |||
| - Round ELASTIC_APM_SAMPLING_RATE with 4 digits precision {pull}828[#(828)] | |||
| - module/apmhttp: implement io.ReaderFrom in wrapped http.ResponseWriter {pull}830[#(830)] | |||
| - Fixed Transaction.Discard so that it sets TransactionData to nil {pull}836[#(836)] | |||
There was a problem hiding this comment.
shouldn't this be under "bug fixes"?
There was a problem hiding this comment.
The Go agent changelog has not, to date, separated additions from fixes. There's a template comment above with a "bug fixes" section, but it's not used anywhere. Maybe it should be...
I'd like to defer that to when we release, and look at what the other agents are doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Transaction.Discard so that it sets TransactionData
to nil, like its documentation says. This is necessary
to avoid adding a transaction to the
sync.Poolmultipletimes (e.g. by calling End after after it has been discarded.)
Closes #835