Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmhttp: implement io.ReaderFrom in wrapper #830

Merged
merged 2 commits into from Oct 7, 2020

Conversation

axw
Copy link
Member

@axw axw commented Oct 6, 2020

If the http.ResponseWriter implements io.ReaderFrom,
make sure the wrapped ResponseWriter also does and
passes through.

Closes #826

If the http.ResponseWriter implements io.ReaderFrom,
make sure the wrapped ResponseWriter also does and
passes through.

Closes elastic#826
@apmmachine
Copy link
Collaborator

apmmachine commented Oct 6, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #830 updated]

  • Start Time: 2020-10-06T09:13:48.940+0000

  • Duration: 23 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 7543
Skipped 182
Total 7725

@axw axw marked this pull request as ready for review October 6, 2020 09:47
@axw axw requested a review from a team October 6, 2020 09:47
@axw axw merged commit 8b847bd into elastic:master Oct 7, 2020
@axw axw deleted the apmhttp-readerfrom branch October 7, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unimplemented ReadFrom() in wrapped http response writer
3 participants