Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sampling rate precision #828

Merged
merged 4 commits into from Oct 7, 2020
Merged

Implement sampling rate precision #828

merged 4 commits into from Oct 7, 2020

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Oct 5, 2020

Closes #815

@apmmachine
Copy link
Collaborator

apmmachine commented Oct 5, 2020 •
edited

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #828 updated]

  • Start Time: 2020-10-06T13:10:27.054+0000

  • Duration: 9 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 3685
Skipped 120
Total 3805

Steps errors 12

Expand to view the steps failures

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 1 min 20 sec

    • Start Time: 2020-10-06T13:15:31.468+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 0 min 1 sec

    • Start Time: 2020-10-06T13:16:51.391+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 0 min 1 sec

    • Start Time: 2020-10-06T13:16:52.843+0000

    • log

  • Name: Error signal

    • Description:

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-06T13:16:54.286+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 2 min 49 sec

    • Start Time: 2020-10-06T13:15:24.449+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 0 min 2 sec

    • Start Time: 2020-10-06T13:17:13.334+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 0 min 1 sec

    • Start Time: 2020-10-06T13:17:15.213+0000

    • log

  • Name: Error signal

    • Description:

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-06T13:17:16.762+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 2 min 16 sec

    • Start Time: 2020-10-06T13:15:27.691+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 0 min 2 sec

    • Start Time: 2020-10-06T13:17:44.229+0000

    • log

  • Name: Build

    • Description: ./scripts/jenkins/build.sh

    • Duration: 0 min 2 sec

    • Start Time: 2020-10-06T13:17:45.779+0000

    • log

  • Name: Error signal

    • Description:

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-06T13:17:47.331+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-10-06T13:19:35.295Z] === RUN   TestSpanDuration
[2020-10-06T13:19:35.556Z] --- PASS: TestSpanDuration (0.51s)
[2020-10-06T13:19:35.557Z] === RUN   TestStatementTruncation
[2020-10-06T13:19:35.557Z] --- PASS: TestStatementTruncation (0.00s)
[2020-10-06T13:19:35.557Z] === RUN   TestStatementNonSearch
[2020-10-06T13:19:35.557Z] --- PASS: TestStatementNonSearch (0.01s)
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBody
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBody/_search
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBody/_msearch
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBody/_search/template
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBody/_msearch/template
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBody/_rollup_search
[2020-10-06T13:19:35.557Z] --- PASS: TestStatementGetBody (0.03s)
[2020-10-06T13:19:35.557Z]     --- PASS: TestStatementGetBody/_search (0.01s)
[2020-10-06T13:19:35.557Z]     --- PASS: TestStatementGetBody/_msearch (0.01s)
[2020-10-06T13:19:35.557Z]     --- PASS: TestStatementGetBody/_search/template (0.00s)
[2020-10-06T13:19:35.557Z]     --- PASS: TestStatementGetBody/_msearch/template (0.01s)
[2020-10-06T13:19:35.557Z]     --- PASS: TestStatementGetBody/_rollup_search (0.01s)
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBodyErrors
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBodyErrors/GetBody
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBodyErrors/Read
[2020-10-06T13:19:35.557Z] === RUN   TestStatementGetBodyErrors/Close
[2020-10-06T13:19:35.557Z] --- PASS: TestStatementGetBodyErrors (0.01s)
[2020-10-06T13:19:35.557Z]     --- PASS: TestStatementGetBodyErrors/GetBody (0.00s)
[2020-10-06T13:19:35.557Z]     --- PASS: TestStatementGetBodyErrors/Read (0.00s)
[2020-10-06T13:19:35.557Z]     --- PASS: TestStatementGetBodyErrors/Close (0.00s)
[2020-10-06T13:19:35.557Z] === RUN   TestStatementBodyReadError
[2020-10-06T13:19:35.557Z] --- PASS: TestStatementBodyReadError (0.00s)
[2020-10-06T13:19:35.557Z] === RUN   TestStatementBodyGzipContentEncoding
[2020-10-06T13:19:35.557Z] --- PASS: TestStatementBodyGzipContentEncoding (0.00s)
[2020-10-06T13:19:35.557Z] === RUN   TestDestination
[2020-10-06T13:19:35.557Z] --- PASS: TestDestination (0.01s)
[2020-10-06T13:19:35.557Z] PASS
[2020-10-06T13:19:35.557Z] ok  	go.elastic.co/apm/module/apmelasticsearch	0.597s
[2020-10-06T13:19:37.471Z] === RUN   TestElastic
[2020-10-06T13:19:37.471Z] --- SKIP: TestElastic (0.00s)
[2020-10-06T13:19:37.471Z]     elastic_integration_test.go:41: ELASTICSEARCH_URL not specified
[2020-10-06T13:19:37.471Z] === RUN   TestOlivereElastic
[2020-10-06T13:19:37.471Z] --- SKIP: TestOlivereElastic (0.00s)
[2020-10-06T13:19:37.471Z]     olivere_integration_test.go:44: ELASTICSEARCH_URL not specified
[2020-10-06T13:19:37.471Z] PASS
[2020-10-06T13:19:37.471Z] ok  	go.elastic.co/apm/module/apmelasticsearch/internal/integration	0.013s
[2020-10-06T13:19:38.857Z] === RUN   TestTraceContextHookNothing
[2020-10-06T13:19:38.857Z] --- PASS: TestTraceContextHookNothing (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestTraceContextHookTransaction
[2020-10-06T13:19:38.857Z] --- PASS: TestTraceContextHookTransaction (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestTraceContextHookSpan
[2020-10-06T13:19:38.857Z] --- PASS: TestTraceContextHookSpan (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestMarshalErrorStack
[2020-10-06T13:19:38.857Z] --- PASS: TestMarshalErrorStack (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestWriter
[2020-10-06T13:19:38.857Z] --- PASS: TestWriter (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestWriterTraceContext
[2020-10-06T13:19:38.857Z] --- PASS: TestWriterTraceContext (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestWriterNonError
[2020-10-06T13:19:38.857Z] --- PASS: TestWriterNonError (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestWriterMinLevel
[2020-10-06T13:19:38.857Z] --- PASS: TestWriterMinLevel (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestWriterWithError
[2020-10-06T13:19:38.857Z] --- PASS: TestWriterWithError (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestWriterWithErrorPkgErrorsStackMarshaler
[2020-10-06T13:19:38.857Z] --- PASS: TestWriterWithErrorPkgErrorsStackMarshaler (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestWriterTracerClosed
[2020-10-06T13:19:38.857Z] --- PASS: TestWriterTracerClosed (0.00s)
[2020-10-06T13:19:38.857Z] === RUN   TestWriterFatal
[2020-10-06T13:19:38.857Z] --- PASS: TestWriterFatal (0.02s)
[2020-10-06T13:19:38.857Z] PASS
[2020-10-06T13:19:38.857Z] ok  	go.elastic.co/apm/module/apmzerolog	0.065s
[2020-10-06T13:19:38.857Z] + status=0
[2020-10-06T13:19:38.857Z] + go get -v -u github.com/jstemmer/go-junit-report
[2020-10-06T13:19:38.857Z] Fetching https://proxy.golang.org/github.com/jstemmer/go-junit-report/@v/list
[2020-10-06T13:19:38.857Z] go: finding github.com/jstemmer/go-junit-report v0.9.1
[2020-10-06T13:19:38.857Z] Fetching https://proxy.golang.org/github.com/jstemmer/go-junit-report/@v/v0.9.1.info
[2020-10-06T13:19:38.857Z] Fetching https://proxy.golang.org/github.com/jstemmer/go-junit-report/@v/v0.9.1.mod
[2020-10-06T13:19:38.857Z] go: downloading github.com/jstemmer/go-junit-report v0.9.1
[2020-10-06T13:19:38.857Z] Fetching https://proxy.golang.org/github.com/jstemmer/go-junit-report/@v/v0.9.1.zip
[2020-10-06T13:19:38.857Z] go: extracting github.com/jstemmer/go-junit-report v0.9.1
[2020-10-06T13:19:38.857Z] github.com/jstemmer/go-junit-report/parser
[2020-10-06T13:19:38.857Z] github.com/jstemmer/go-junit-report/formatter
[2020-10-06T13:19:39.118Z] github.com/jstemmer/go-junit-report
[2020-10-06T13:19:39.378Z] + go-junit-report
[2020-10-06T13:19:39.378Z] + exit 0
[2020-10-06T13:19:39.444Z] Recording test results
[2020-10-06T13:19:41.229Z] Stage "Coverage" skipped due to earlier failure(s)
[2020-10-06T13:19:41.267Z] Stage "Benchmark" skipped due to earlier failure(s)
[2020-10-06T13:19:41.343Z] Stage "More OS" skipped due to earlier failure(s)
[2020-10-06T13:19:41.377Z] Stage "Windows" skipped due to earlier failure(s)
[2020-10-06T13:19:41.380Z] Stage "OSX" skipped due to earlier failure(s)
[2020-10-06T13:19:41.417Z] Failed in branch Windows
[2020-10-06T13:19:41.419Z] Failed in branch OSX
[2020-10-06T13:19:41.480Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-10-06T13:19:41.526Z] Stage "Release" skipped due to earlier failure(s)
[2020-10-06T13:19:41.546Z] Stage "Release" skipped due to earlier failure(s)
[2020-10-06T13:19:41.776Z] Running on Jenkins in /var/lib/jenkins/workspace/agent-go_apm-agent-go-mbp_PR-828
[2020-10-06T13:19:41.874Z] [INFO] getVaultSecret: Getting secrets
[2020-10-06T13:19:42.067Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-10-06T13:19:42.701Z] + chmod 755 generate-build-data.sh
[2020-10-06T13:19:42.701Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-828/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-828/runs/2 FAILURE 555384
[2020-10-06T13:19:42.952Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-828/runs/2/steps/?limit=10000 -o steps-info.json
[2020-10-06T13:19:44.295Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-go/apm-agent-go-mbp/PR-828/runs/2/tests/?status=FAILED -o tests-errors.json

axw
axw approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks. Please update the doc comment and changelog.

sampler.go Show resolved Hide resolved
@jalvz jalvz merged commit bde10dd into elastic:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement sample_rate precision spec
3 participants
@jalvz @apmmachine @axw