Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outcome #820

Merged
merged 5 commits into from Sep 24, 2020
Merged

Outcome #820

merged 5 commits into from Sep 24, 2020

Conversation

axw
Copy link
Member

@axw axw commented Sep 24, 2020

Add the Outcome field to Transactions and Spans.

If when a transaction or span is ended, its outcome has not been specified, we either use some protocol/instrumentation-specific logic to set a default, or otherwise set it to "unknown". For HTTP and gRPC, we use the status code to set the outcome.

  • HTTP server side: "success" for status codes < 500, "failure" otherwise.
  • HTTP client side: "success" for status codes < 400, "failure" otherwise.
  • gRPC server side:
    • "unknown" for status code Unknown
    • "failure" for status codes DataLoss, Unavailable, Internal, and Unimplemented
    • "success" otherwise
  • gRPC client side:
    • "unknown" for status code Unknown
    • "success" for status code OK
    • "failure" otherwise

Closes #799

Add the Outcome field to Transaction and Span,
sanitize/normalize (replace unexpected values
with "unknown").
@apmmachine
Copy link
Collaborator

apmmachine commented Sep 24, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #820 updated]

  • Start Time: 2020-09-24T03:53:08.210+0000

  • Duration: 23 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 7456
Skipped 182
Total 7638

@axw axw marked this pull request as ready for review September 24, 2020 06:11
@axw axw requested a review from a team September 24, 2020 06:11
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@axw axw merged commit 4f71814 into elastic:master Sep 24, 2020
@axw axw deleted the outcome branch September 24, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: {Transaction,Span}.Outcome
3 participants