Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/apmhostutil: relax k8s cgroup regex #819

Merged
merged 2 commits into from Sep 21, 2020
Merged

Conversation

axw
Copy link
Member

@axw axw commented Sep 17, 2020

Relax the regular expression to match additional paths like:

  • 12:pids:/kubepods/kubepods/besteffort/pod0e886e9a-3879-45f9-b44d-86ef9df03224/244a65edefdffe31685c42317c9054e71dc1193048cf9459e2a4dd35cbc1dba4
  • 10:cpuset:/kubepods/pod5eadac96-ab58-11ea-b82b-0242ac110009/7fe41c8a2d1da09420117894f11dd91f6c3a44dfeb7d125dc594bd53468861df

Closes #783

Relax the regular expression to match additional paths like:

- 12:pids:/kubepods/kubepods/besteffort/pod0e886e9a-3879-45f9-b44d-86ef9df03224/244a65edefdffe31685c42317c9054e71dc1193048cf9459e2a4dd35cbc1dba4
- 10:cpuset:/kubepods/pod5eadac96-ab58-11ea-b82b-0242ac110009/7fe41c8a2d1da09420117894f11dd91f6c3a44dfeb7d125dc594bd53468861df
@axw axw requested a review from a team September 17, 2020 03:30
@axw axw marked this pull request as ready for review September 17, 2020 03:30
@apmmachine
Copy link
Collaborator

apmmachine commented Sep 17, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #819 updated]

  • Start Time: 2020-09-17T03:29:43.124+0000

  • Duration: 22 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 7405
Skipped 182
Total 7587

@axw axw changed the title internal/apmhostutil: relax k8ds cgroup regex internal/apmhostutil: relax k8s cgroup regex Sep 18, 2020
@axw axw merged commit 3764442 into elastic:master Sep 21, 2020
@axw axw deleted the relax-k8s-regex branch September 21, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax k8s pod ID discovery regex
3 participants