Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmsql: add support for Validator interface #791

Merged
merged 1 commit into from Jul 27, 2020

Conversation

axw
Copy link
Member

@axw axw commented Jul 27, 2020

Add support for the driver.Validator interface coming in Go 1.15.

Pin go-sysinfo to v1.3.0 for Go < 1.11.0, which lack support for AIX
(go-sysinfo v1.14.0 added AIX support)

@apmmachine
Copy link
Collaborator

apmmachine commented Jul 27, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #791 updated]

  • Start Time: 2020-07-27T06:15:39.944+0000

  • Duration: 24 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 7263
Skipped 182
Total 7445

@axw axw marked this pull request as draft July 27, 2020 05:57
Add support for the driver.Validator interface coming in Go 1.15.
@axw axw marked this pull request as ready for review July 27, 2020 06:53
@axw axw merged commit b6aa1e9 into elastic:master Jul 27, 2020
@axw axw deleted the go115-driver-validator branch July 27, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants