Implement CloseIdleConnections on apmelasticsearch #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yikes. Thanks for the PR! Can you please add a mention of this in https://github.com/elastic/apm-agent-go/blob/master/CHANGELOG.asciidoc, in the "unreleased" section? |
axw
approved these changes
Apr 21, 2020
|
Test failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The apmelasticsearch
roundTripperdid not implementCloseIdleConnectionsand we (@charith-elastic who did the investigation) believe we observed a goroutine leak as a consequence of that.This PR adds support for
CloseIdleConnectionsand propagates it to the wrapped transport/RoundTripperif it implements it.