Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More central configuration enablement #742

Merged
merged 1 commit into from Apr 1, 2020
Merged

Conversation

axw
Copy link
Member

@axw axw commented Apr 1, 2020

Enable central configuration for:

  • stack_frames_min_duration
  • stack_trace_limit

Closes #741

Enable central configuration for:
 - stack_frames_min_duration
 - stack_trace_limit
@codecov-io
Copy link

Codecov Report

Merging #742 into master will increase coverage by 0.08%.
The diff coverage is 79.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #742      +/-   ##
==========================================
+ Coverage   84.59%   84.68%   +0.08%     
==========================================
  Files         127      127              
  Lines        8271     8350      +79     
==========================================
+ Hits         6997     7071      +74     
- Misses        892      894       +2     
- Partials      382      385       +3     
Impacted Files Coverage Δ
module/apmecho/middleware.go 88.77% <0.00%> (ø)
module/apmechov4/middleware.go 88.77% <0.00%> (ø)
module/apmgin/middleware.go 86.84% <0.00%> (ø)
module/apmhttprouter/handler.go 76.19% <0.00%> (ø)
module/apmrestful/filter.go 90.00% <0.00%> (ø)
profiling.go 71.87% <0.00%> (-3.54%) ⬇️
module/apmzap/core.go 64.10% <50.00%> (ø)
config.go 76.63% <62.50%> (-0.25%) ⬇️
tracer.go 88.85% <84.21%> (+1.49%) ⬆️
error.go 95.09% <100.00%> (+0.13%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f723b...4668b77. Read the comment docs.

@axw axw merged commit e34337f into elastic:master Apr 1, 2020
@axw axw deleted the more-remote-config branch April 1, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add central config support for span_frames_min_duration, stack_trace_limit
2 participants