Introduce "recording" config #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmorelli25 could you please take a gander at the docs addition? https://github.com/elastic/apm-agent-go/pull/737/files#diff-01c1a79a5a1e1b67003a1885365f2cf5 |
axw
force-pushed
the
recording
branch
2 times, most recently
from
0ec0568
to
97b51cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
==========================================
+ Coverage 84.59% 84.69% +0.09%
==========================================
Files 127 127
Lines 8271 8330 +59
==========================================
+ Hits 6997 7055 +58
Misses 891 891
- Partials 383 384 +1
Continue to review full report at Codecov.
|
|
Leaving this open until elastic/kibana#61179 is done, so I can test e2e |
bmorelli25
reviewed
Mar 26, 2020
We introduce the ELASTIC_APM_RECORDING configuration. This is a boolean configuration that defaults to true, controlling whether events are recorded and sent. When recording is true there should be no change; when false: - Transactions will always be recorded as "unsampled", and will be silently discarded when ended, without affecting tracer statistics - Spans will all be dropped by virtue of transactions all being unsampled - Captured errors will not have details filled in, and will be silently discarded when "sent" without affecting tracer statistics - Breakdown metrics will not be updated - Metrics gathering will be disabled Recording can be updated via central config and by using the new Tracer.SetRecording method. We also introduce a new Tracer.Recording method which reports whether events are being recorded. If the tracer is inactive (Tracer.Active returns false), then Tracer.Recording will also return false. This new method can be used by instrumentation to avoid expensive instrumentation paths when recording is disabled. We have updated all provided instrumentation modules to use the new Tracer.Recording method instead of Tracer.Active.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce the ELASTIC_APM_RECORDING configuration.
This is a boolean configuration that defaults to true,
controlling whether events are recorded and sent. When
recording is true there should be no change; when false:
and will be silently discarded when ended, without
affecting tracer statistics
all being unsampled
will be silently discarded when "sent" without affecting
tracer statistics
Recording can be updated via central config and by using
the new Tracer.SetRecording method.
We also introduce a new Tracer.Recording method which
reports whether events are being recorded. If the tracer
is inactive (Tracer.Active returns false), then
Tracer.Recording will also return false. This new method
can be used by instrumentation to avoid expensive
instrumentation paths when recording is disabled. We have
updated all provided instrumentation modules to use the
new Tracer.Recording method instead of Tracer.Active.