Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module/apmsql: report rows affected #700

Merged
merged 2 commits into from Jan 10, 2020
Merged

module/apmsql: report rows affected #700

merged 2 commits into from Jan 10, 2020

Conversation

axw
Copy link
Member

@axw axw commented Jan 9, 2020

Record the number of rows affected for Exec/ExecContext calls.

Closes #578

@codecov-io
Copy link

codecov-io commented Jan 9, 2020 •
edited

Codecov Report

Merging #700 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #700   +/-   ##
=======================================
  Coverage   85.21%   85.21%           
=======================================
  Files         127      127           
  Lines        8443     8443           
=======================================
  Hits         7195     7195           
  Misses        879      879           
  Partials      369      369

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3f304...86669ee. Read the comment docs.

@axw axw merged commit 95fed16 into elastic:master Jan 10, 2020
@axw axw deleted the sql-rows-affected branch January 10, 2020 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

module/apmsql: record number of rows affected
2 participants
@axw @codecov-io