Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for API Key auth #698

Merged
merged 2 commits into from Jan 7, 2020
Merged

Add support for API Key auth #698

merged 2 commits into from Jan 7, 2020

Conversation

axw
Copy link
Member

@axw axw commented Jan 6, 2020

Add support for API Key auth. API Key auth can be configured by specifying a base64-encoded API Key via the environment variable ELASTIC_APM_API_KEY.

We also add support for running the Gherkin feature tests defined in https://github.com/elastic/apm/tree/master/tests/agents/gherkin-specs

Closes #694

@axw axw force-pushed the apikey branch 2 times, most recently from 4b069af to a0dcfc9 Compare January 6, 2020 10:01
@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #698 into master will decrease coverage by 0.88%.
The diff coverage is 81.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #698      +/-   ##
=========================================
- Coverage   85.59%   84.7%   -0.89%     
=========================================
  Files         125     127       +2     
  Lines        8516    8260     -256     
=========================================
- Hits         7289    6997     -292     
- Misses        865     884      +19     
- Partials      362     379      +17
Impacted Files Coverage Δ
transport/http.go 85.84% <77.77%> (-0.91%) ⬇️
internal/apmgodog/formatter.go 79.03% <79.03%> (ø)
internal/apmgodog/suitecontext.go 84.31% <84.31%> (ø)
config.go 76.88% <0%> (-10.23%) ⬇️
tracer.go 88.3% <0%> (-3.45%) ⬇️
breakdown.go 95.2% <0%> (-1.32%) ⬇️
transaction.go 93.33% <0%> (-1.3%) ⬇️
model/marshal_fastjson.go 66.94% <0%> (-0.28%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4948a81...71a1a25. Read the comment docs.

@axw axw merged commit c9b3406 into elastic:master Jan 7, 2020
@axw axw deleted the apikey branch January 7, 2020 06:17
@@ -0,0 +1,18 @@
Feature: Api Key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @axw, this is great!!! Very happy you added Godog in the agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for API Key auth
3 participants