Add "tracestate" propagation #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the field TraceContext.State, which has the new type TraceState. TraceState is an opaque type, which internally contains a list of TraceStateEntry objects. When starting a transaction with StartTransactionOptions, the TraceContext.State field will only be considered if both TraceContext.Trace and TraceContext.State are valid. If this is true, then the state will be stored on the transaction, and spans created using the transaction. Server instrumentation in apmhttp, apmgrpc, and apmot will extract and parse "tracestate" headers, while client instrumentation will inject "tracestate" headers. Add missing docs for `ELASTIC_APM_USE_ELASTIC_TRACEPARENT_HEADER`.
|
jenkins run the tests |
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
==========================================
+ Coverage 88.18% 88.33% +0.15%
==========================================
Files 125 125
Lines 8354 8446 +92
==========================================
+ Hits 7367 7461 +94
+ Misses 849 846 -3
- Partials 138 139 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the field TraceContext.State, which has the new
type TraceState. TraceState is an opaque type, which
internally contains a list of TraceStateEntry objects.
When starting a transaction with StartTransactionOptions,
the TraceContext.State field will only be considered if
both TraceContext.Trace and TraceContext.State are valid.
If this is true, then the state will be stored on the
transaction, and spans created using the transaction.
Server instrumentation in apmhttp, apmgrpc, and apmot
will extract and parse "tracestate" headers, while client
instrumentation will inject "tracestate" headers.
Add missing docs for
ELASTIC_APM_USE_ELASTIC_TRACEPARENT_HEADER.Closes #503
Closes #685