Add span.context.destination.* #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
==========================================
- Coverage 88.18% 87.73% -0.46%
==========================================
Files 125 125
Lines 8354 8047 -307
==========================================
- Hits 7367 7060 -307
- Misses 849 872 +23
+ Partials 138 115 -23
Continue to review full report at Codecov.
|
axw
force-pushed
the
destination-address
branch
from
8d43e88
to
f9cabc8
Compare
axw
force-pushed
the
destination-address
branch
4 times, most recently
from
9dc010f
to
c853e9b
Compare
|
jenkins run the tests please |
axw
changed the title
axw
force-pushed
the
destination-address
branch
3 times, most recently
from
5cfaa1b
to
c351dae
Compare
|
Waiting for elastic/apm-server#3053 to land, so the vendored schema can be updated for testing. |
Add span.context fields: - destination.address - destination.port - destination.service.type - destination.service.name - destination.service.resource Implement support for (client) HTTP, Elasticsearch, PostgreSQL and MySQL (via apmsql or GORM) spans.
axw
force-pushed
the
destination-address
branch
from
c351dae
to
564672e
Compare
|
jenkins run the tests please |
2 similar comments
|
jenkins run the tests please |
|
jenkins run the tests please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add span.context fields:
Implement support for (client) HTTP,
Elasticsearch, PostgreSQL and MySQL
(via apmsql or GORM) spans.
Closes #676