Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added RedisClient() to return underlaying redis.Client #613

Merged
merged 1 commit into from Aug 19, 2019

Conversation

wins1908
Copy link

Our code is using *redis.Client, we need to add a method to return underlaying redis.client after called WithContext()

@elasticcla
Copy link

Hi @wins1908, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@wins1908
Copy link
Author

wins1908 commented Aug 16, 2019 via email

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wins1908, LGTM

@axw
Copy link
Member

axw commented Aug 18, 2019

jenkins run the tests please

@codecov-io
Copy link

codecov-io commented Aug 18, 2019

Codecov Report

Merging #613 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   87.77%   87.72%   -0.05%     
==========================================
  Files         122      122              
  Lines        7483     7489       +6     
==========================================
+ Hits         6568     6570       +2     
- Misses        811      816       +5     
+ Partials      104      103       -1
Impacted Files Coverage Δ
module/apmgoredis/client.go 77.04% <0%> (-8.41%) ⬇️
tracer.go 89.69% <0%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7215d0a...7b71fb1. Read the comment docs.

@axw axw merged commit ca8f581 into elastic:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants