Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WithPanicPropagation function #611

Merged
merged 1 commit into from Aug 8, 2019

Conversation

yklyahin
Copy link
Contributor

@yklyahin yklyahin commented Aug 7, 2019

I added a feature for panic propagation.

More details:
#540
https://discuss.elastic.co/t/go-agent-apmhttp-middleware/193927/2

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lobotomist, looks great!

@axw
Copy link
Member

axw commented Aug 8, 2019

jenkins run the tests please

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

Merging #611 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   87.74%   87.79%   +0.05%     
==========================================
  Files         122      122              
  Lines        7476     7483       +7     
==========================================
+ Hits         6560     6570      +10     
+ Misses        814      810       -4     
- Partials      102      103       +1
Impacted Files Coverage Δ
module/apmhttp/handler.go 83.2% <100%> (-0.7%) ⬇️
tracer.go 89.69% <0%> (+0.32%) ⬆️
transport/http.go 95.41% <0%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfee654...12143d4. Read the comment docs.

@axw axw merged commit 7215d0a into elastic:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants