Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmgoredisv8: batched commands can create long span names #1550

Open
axw opened this issue Dec 14, 2023 · 0 comments
Open

module/apmgoredisv8: batched commands can create long span names #1550

axw opened this issue Dec 14, 2023 · 0 comments
Labels

Comments

@axw
Copy link
Member

axw commented Dec 14, 2023

Describe the bug

If you have a batch of Redis commands they will result in one batch span that is the concatenation of all the command names. That can get arbitrarily long.

image

Expected behavior

We should probably follow the span compression feature, and replace runs of command names with x<N> COMMAND.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant