Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation support for segmentio/kafka-go #1471

Open
sohaibomr opened this issue Jun 17, 2023 · 4 comments
Open

Add instrumentation support for segmentio/kafka-go #1471

sohaibomr opened this issue Jun 17, 2023 · 4 comments
Labels

Comments

@sohaibomr
Copy link

sohaibomr commented Jun 17, 2023

Is your feature request related to a problem? Please describe.
There doesn't seem to be a client for instrumenting Kafka, especially for tracing Kafka messages across multiple microservices. It will be helpful to have this support to achieve distributed async tracing in event-driven architecture where kaka is used as a messaging queue.

Describe the solution you'd like
Support for instrumentation in segmentio/kafka-go kafka client.

@axw
Copy link
Member

axw commented Jun 19, 2023

Thanks for opening the issue @sohaibomr

As an alternative to native instrumentation in the Go Agent, another option would be to use OpenTelemetry instrumentation for kafka-go with the recently added apmotel module. There's an open issue about adding OTel instrumentation for kafka-go (segmentio/kafka-go#1025).

@sohaibomr
Copy link
Author

Let me look into the alternative approach you suggested.
Thanks @axw

@sohaibomr
Copy link
Author

@axw I attempted to add this support in apm-agent-go which seems to work for me. I can create a PR if you are accepting contributions.
You may have a look at it here.
thanks

@axw
Copy link
Member

axw commented Jul 3, 2023

@sohaibomr nice work! Thanks for the offer, will discuss with the team. If nothing else, we might point to your repo from some docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants