Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the "Babel + browserslist defaults config hack" #33

Closed
JulianKniephoff opened this issue Aug 17, 2020 · 1 comment · Fixed by #420
Closed

Get rid of the "Babel + browserslist defaults config hack" #33

JulianKniephoff opened this issue Aug 17, 2020 · 1 comment · Fixed by #420
Assignees
@JulianKniephoff
Labels
area:frontend Everything frontend related kind:refactor Refactoring, cleanup or anything else that improves code quality priority:low Low priority status:blocked Blocked by something else time:minutes Time estimate: less than an hour

Comments

@JulianKniephoff
Copy link
Member

JulianKniephoff commented Aug 17, 2020 •
edited

See aa24989.

We also might want to consider to revert .babelrc.js back to a JSON file if there isn't any other reason for it being a script, since it should decrease build times.

We could also move the browserslist config to its own file then, although the docs actually recommend having it in the package.json file. What I don't like about that is that you can't add comments, there.
@JulianKniephoff JulianKniephoff added area:frontend Everything frontend related kind:refactor Refactoring, cleanup or anything else that improves code quality status:blocked Blocked by something else time:minutes Time estimate: less than an hour priority:low Low priority labels Aug 17, 2020
@JulianKniephoff
Copy link
Member Author

Things might change here with Babel 8: See babel/babel#9962 and babel/babel#10746.

Until then, we can't really do anything here, I guess.

JulianKniephoff added a commit to JulianKniephoff/tobira that referenced this issue Apr 29, 2022
@JulianKniephoff
Stop duplicating browserslist configuration
72b8599 
Closes elan-ev#33.
@JulianKniephoff JulianKniephoff mentioned this issue Apr 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JulianKniephoff JulianKniephoff

Labels
area:frontend Everything frontend related kind:refactor Refactoring, cleanup or anything else that improves code quality priority:low Low priority status:blocked Blocked by something else time:minutes Time estimate: less than an hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop duplicating browserslist config JulianKniephoff/tobira
1 participant
@JulianKniephoff