Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Option] Some options changes should invalidate the container definition #10

Open
fancyweb opened this issue Dec 3, 2018 · 0 comments
Open

[Option] Some options changes should invalidate the container definition #10

fancyweb opened this issue Dec 3, 2018 · 0 comments
Assignees
@fancyweb

Comments

@fancyweb
Copy link
Contributor

fancyweb commented Dec 3, 2018

When some options are changed, the container definition should be invalidated.

Example :

  • I use the DisplayPrettyExceptionsAction with a logger.
  • The container definition gets cached.
  • I remove the logger from the options.
  • The cached container definition is used, but since the service exists the logger is expected in the options.

Or maybe we can be more lax in the check in the actions for those cases. It need to be checked carefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fancyweb fancyweb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fancyweb